Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed RF 1 Write Multiport Read from Bender.yml to avoid duplication. #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yvantor
Copy link

@yvantor yvantor commented May 10, 2023

Removing register_file_1w_multi_port_read.sv as a duplication of the one in scm/latch_scm one but with different clock gating cells.

@micprog
Copy link
Member

micprog commented May 10, 2023

I don't know if it makes sense to remove the file, AFAIK it is used in the simulation flow. Removing it from the bender.yml definitely makes sense though!

@yvantor
Copy link
Author

yvantor commented May 10, 2023

I don't know if it makes sense to remove the file, AFAIK it is used in the simulation flow. Removing it from the bender.yml definitely makes sense though!

My point is that if we remove it from bender we are also not using the file for simulations, is this correct? In addition, having SCM in the deps already allows the usage of register_file_1w_multi_port_read.sv but there is no module repetition. The two sv files are identical, the only difference is using tc_clk_gating/cluster_clk_gating for the gating cells. I can push the file back in the repo anyway

@micprog
Copy link
Member

micprog commented May 10, 2023

vlog -quiet -sv ../RTL/L1_CACHE/register_file_1w_multi_port_read.sv
vlog -quiet -sv ../RTL/L1_CACHE/register_file_1w_multi_port_read_test_wrap.sv

This is my main concern, ensuring that the testbench will still function correctly. I see two options: 1. keep the file in the repository currently, or 2. adjust the above lines accordingly.

Of course, updating the testbench to work with bender would be best, but time investment would be needed.

@yvantor
Copy link
Author

yvantor commented May 10, 2023

vlog -quiet -sv ../RTL/L1_CACHE/register_file_1w_multi_port_read.sv
vlog -quiet -sv ../RTL/L1_CACHE/register_file_1w_multi_port_read_test_wrap.sv

This is my main concern, ensuring that the testbench will still function correctly. I see two options: 1. keep the file in the repository currently, or 2. adjust the above lines accordingly.

Of course, updating the testbench to work with bender would be best, but time investment would be needed.

I got it and I perfectly agree on point 1

@yvantor yvantor changed the title Removed RF 1 Write Multiport Read as duplicated from SCM. Removed RF 1 Write Multiport Read from Bender.yml to avoid duplication. May 10, 2023
@yvantor
Copy link
Author

yvantor commented May 10, 2023

vlog -quiet -sv ../RTL/L1_CACHE/register_file_1w_multi_port_read.sv
vlog -quiet -sv ../RTL/L1_CACHE/register_file_1w_multi_port_read_test_wrap.sv

This is my main concern, ensuring that the testbench will still function correctly. I see two options: 1. keep the file in the repository currently, or 2. adjust the above lines accordingly.
Of course, updating the testbench to work with bender would be best, but time investment would be needed.

I got it and I perfectly agree on point 1

It should be better now

Copy link
Member

@micprog micprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants