-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed RF 1 Write Multiport Read from Bender.yml to avoid duplication. #11
base: master
Are you sure you want to change the base?
Conversation
I don't know if it makes sense to remove the file, AFAIK it is used in the simulation flow. Removing it from the bender.yml definitely makes sense though! |
My point is that if we remove it from bender we are also not using the file for simulations, is this correct? In addition, having SCM in the deps already allows the usage of register_file_1w_multi_port_read.sv but there is no module repetition. The two sv files are identical, the only difference is using tc_clk_gating/cluster_clk_gating for the gating cells. I can push the file back in the repo anyway |
Lines 36 to 37 in 3fcc6da
This is my main concern, ensuring that the testbench will still function correctly. I see two options: 1. keep the file in the repository currently, or 2. adjust the above lines accordingly. Of course, updating the testbench to work with bender would be best, but time investment would be needed. |
I got it and I perfectly agree on point 1 |
c27fc5b
to
61514b2
Compare
It should be better now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Removing register_file_1w_multi_port_read.sv as a duplication of the one in scm/latch_scm one but with different clock gating cells.